Smarter fuzzy completion matches #1449
Open
+68
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename parameter "orig_text" and don't overwrite "text". * Limit regex fuzzy match to 3-character intervening spans for performance and readability of results. * Add underscore-split match. If the underscore-split words in the text are a subset of the underscore-split words in the completion item, we have a match. * Add CamelCase-split match. If the CamelCase-split words in the text are a subset of the CamelCase-split words in the completion item, we have a match. * Remove unused length and position values from tuples, letting "completions" be just a list of strings. The words within the underscore and camel-split matches are not themselves fuzzy, and must be exact matches. It might be neat if we accepted leading substrings from all of the words instead. Beyond that, if we need anything more fancy we should use a library rather than rolling our own.
Contributor
|
RE: the split match functionality, I am comparing it to main and it seems to work the same as far as I can tell. Is there another case that highlights the expected difference? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
orig_textand don't overwritetext.The words within the underscore and camel-split matches are not themselves fuzzy, and must be exact matches. It might be neat if we accepted leading substrings from all of the words instead.
Beyond that, if we need anything more fancy we should use a library rather than rolling our own.
This may close some open issues.
Will cause a merge conflict with #1448, to be resolved later.
Like #1448, the inspiration is to improve completions after adding more possible matches in #1447.
Example showing underscore-split match:
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.